search

NordicSemiconductor / Android-nRF-Toolbox

The nRF Toolbox is a container app that stores your Nordic Semiconductor apps for Bluetooth Low Energy in one location.
https://www.nordicsemi.com/Software-and-tools/Development-Tools/nRF-Toolbox
BSD 3-Clause "New" or "Revised" License
1.07k stars 461 forks source link

Gradle Plugin 3.3.0 proguard-rules fix #64

Closed bluefirepatrick closed 5 years ago

bluefirepatrick commented 5 years ago

This fix is only necessary if you update to Gradle Plugin 3.3.0 so feel free to disregard if you are staying on 3.2.1.

The issues seems to be that Gradle Plugin 3.3.0 requires jar files to be specified in proguard files instead of directories.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

philips77 commented 5 years ago

I've removed the proguard rule completely and it seems to work fine without it. If I find any issues I'll implement your change. Closing the PR for now. Thanks for the contribution!