NordicSemiconductor / IOS-CoreBluetooth-Mock

Mocking library for CoreBluetooth framework.
BSD 3-Clause "New" or "Revised" License
225 stars 51 forks source link

Remove peripheral after disconnect #102

Closed everlof closed 6 months ago

everlof commented 10 months ago

If we don't remove the peripheral, it will be reused (containing the services currently present). This is not how CBPeripheral works, there will be no services present after a disconnect -> connect.

CLAassistant commented 10 months ago

CLA assistant check
All committers have signed the CLA.

everlof commented 10 months ago

Don't know how to get the CLA fixed. I've signed it and added the email I used to my account. I've also tried to trigger a "recheck"...

philips77 commented 10 months ago

You need to set up your git to use your e-mail address.

Your Identity The first thing you should do when you install Git is to set your user name and email address. This is important because every Git commit uses this information, and it’s immutably baked into the commits you start creating:

  $ git config --global user.name "John Doe"
  $ git config --global user.email johndoe@example.com

Then amend your last commit and force push it again to this branch. If you signed the CLA with that e-mail, it will work.

everlof commented 10 months ago

You need to set up your git to use your e-mail address.

Your Identity The first thing you should do when you install Git is to set your user name and email address. This is important because every Git commit uses this information, and it’s immutably baked into the commits you start creating:

$ git config --global user.name "John Doe"
$ git config --global user.email johndoe@example.com

Then amend your last commit and force push it again to this branch. If you signed the CLA with that e-mail, it will work.

Great, thanks! That worked out perfect.

everlof commented 6 months ago

Great 🥳