Closed mmllr closed 3 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Hello,
May I know the reason for creating CBMPeer
and CBMAttribute
classes with fatalError()
?
Hi, Xcode 12.5 beta complains about an unavailable -init() for these classes (hard error, in contrast to earlier Xcode versions, subclassing them is forbidden anyway).
CB_EXTERN_CLASS @interface CBPeer : NSObject <NSCopying>
- (instancetype)init NS_UNAVAILABLE;
...
CB_EXTERN_CLASS @interface CBAttribute : NSObject
- (instancetype)init NS_UNAVAILABLE;
My PR is just a quick fix for getting back to a successful compile. All the CBM classes which use CBMAttribute and CBMPeer overwrite the fatalError implementations.
Xcode 12.5 has been released and this issue is still relevant. Are there any plans to release this fix?
Oh, sorry, I completely forgot about this issue. Let me look into it now.
any updates about this PR?
I'll merge and release it asap. Just give me few hours to finish my current tasks.
To be clear, this would completely break the functionality of these classes, no?
If you're using CBMPeripheral
or CBMCentralManager
, or the original names but as typealias
nothing should change.
It's only if you were using the CBPeer
and CBAttribute
types directly, now they are not compatible with CBM..
counterparts.
Yep, it should not break existing code.
Released as 0.12.1.
Signed-off-by: Markus Müller markus.mueller@kf-interactive.com