search

NordicSemiconductor / IOS-CoreBluetooth-Mock

Mocking library for CoreBluetooth framework.
BSD 3-Clause "New" or "Revised" License
225 stars 51 forks source link

fix advertising timer #76

Closed kscheff closed 1 year ago

kscheff commented 2 years ago

fix issue reported in #75

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Kai Scheffer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

philips77 commented 2 years ago

Thank you for the PR. I'll review it as soon as possible, but I'm now buried with other tasks, so it may take a while. I did not think of calling scanForPeripherals multiple times. This can, actually, be called using multiple CBMCentralManager objects, so perhaps a global timer could be better. But I don't remember the details now, so need to spend some time on this.

Anyway, I hope the fix works for you and you can use your fork in the meantime.

kscheff commented 2 years ago

Anyway, I hope the fix works for you and you can use your fork in the meantime.

Thanks, it is now working as a demo alongside with the native stack. Here the App in action: https://apps.apple.com/ch/app/bluebattery/id1233388568