search

NordicSemiconductor / IOS-DFU-Library

OTA DFU Library for Mac and iOS, compatible with nRF5x SoCs
http://www.nordicsemi.com
BSD 3-Clause "New" or "Revised" License
525 stars 214 forks source link

FEAT: add central manager options to DFUServiceInitiator #478

Closed mateusforgi closed 2 years ago

mateusforgi commented 2 years ago

Adding central manager options to DFUServiceInitiator init. This is a breaking change since in swift a function is uniquely identified by its name and its parameters both arguments labels and types. Another option to avoid breaking changes would be to add another init.

https://github.com/NordicSemiconductor/IOS-DFU-Library/issues/476

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

mateusforgi commented 2 years ago

@philips77 I opened this new mr.

philips77 commented 2 years ago

The commit was sent without an e-mail address, so GitHub can't match it to your account. Try doing what was explained here.

philips77 commented 2 years ago

Anyway, I can still merge it if you want.

mateusforgi commented 2 years ago

@philips77 you can merge it, signed the commits.

mateusforgi commented 2 years ago

@philips77 any update on that?