NordicSemiconductor / IOS-nRF-Connect-Device-Manager

A mobile management library for devices supporting nRF Connect Device Manager.
https://www.nordicsemi.com/Software-and-tools/Software/nRF-Connect-SDK
Apache License 2.0
86 stars 37 forks source link

Don't override user settings when Mcu Manager Params are not supported #186

Closed philips77 closed 6 months ago

philips77 commented 6 months ago

This PR removes overriding user configuration when Mcu Manager Params command is not supported by the device. Apparently, some devices don't support this command, but still allow for pipelining making the DFU much faster. If the user wants 6 buffers, let's try to use 6 buffers.

For the current nRF54 implementation (which does not support Mcu Mgr Params) the speed increase is 7Kb/s to 40 kB/s (Pixel 7 with Android 14 achieved top speed 71 kB/s with 6 buffers).