NordicSemiconductor / IOS-nRF-Connect-Device-Manager

A mobile management library for devices supporting nRF Connect Device Manager.
https://www.nordicsemi.com/Software-and-tools/Software/nRF-Connect-SDK
Apache License 2.0
90 stars 41 forks source link

Infinite Confirm/Reset loop when running in testAndConfirm mode. #25

Closed ghost closed 2 years ago

ghost commented 2 years ago

When implementing this library in my own project, I found that if I ran the Firmware Upgrade Manager in testAndConfirm mode, it would do everything properly up until the last step, where instead of marking the state as successful it would just throw itself into an infinite loop of resetting and confirming the firmware.

Changing the self.reset() call to a self.success() call, mimicking FirmwareUpgradeManager's reconnect function fixes this problem.

(Re-submitting from a separate branch so that I can continue to use the master branch on my fork.)

dinesharjani commented 2 years ago

@GriffinJBC thank you very much