The image, in the above case, was marked as uploaded, but not as confirmed or tested, thus the library tried to test it again. As it was already in the primary and secondary slot, the confirm call was acting on the primary slot, but the check was verifying the secondary slot, which was never confirmed (why would it be).
Now, it will not be sent twice in the first place, will be marked as confirmed and no additional confirm commands will be sent.
This PR fixes the endless loop happening when the same image is in both primary and secondary slot of an image. In #55 (and before) the flags of each image in the
imagesproperty in DFU manager were modified multiple times. https://github.com/NordicSemiconductor/IOS-nRF-Connect-Device-Manager/blob/bab7cba94ec1944f99461a8f1a19ca9dcf552d65/Source/Managers/DFU/FirmwareUpgradeManager.swift#L353-L370 However, asFirmwareUpgradeImageis astruct, each modification is effectively replacing the image object with a new struct. The following call tomarkAs...(_ image:)was not finding the image instance, and returning, without changing the flag.The image, in the above case, was marked as uploaded, but not as confirmed or tested, thus the library tried to test it again. As it was already in the primary and secondary slot, the confirm call was acting on the primary slot, but the check was verifying the secondary slot, which was never confirmed (why would it be). Now, it will not be sent twice in the first place, will be marked as confirmed and no additional confirm commands will be sent.