search

NordicSemiconductor / IOS-nRF-Connect-Device-Manager

A mobile management library for devices supporting nRF Connect Device Manager.
https://www.nordicsemi.com/Software-and-tools/Software/nRF-Connect-SDK
Apache License 2.0
90 stars 41 forks source link

Release cyclic reference after upgradeDidComplete #72

Closed RickGroenewegen closed 1 year ago

RickGroenewegen commented 2 years ago

This concerns the following issue:

https://github.com/NordicSemiconductor/IOS-nRF-Connect-Device-Manager/issues/69

The cyclic reference is released too fast so upgradeDidComplete will never fire.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

RickGroenewegen commented 2 years ago

I think it also might fix these issues:

https://github.com/NordicSemiconductor/IOS-nRF-Connect-Device-Manager/issues/71 https://github.com/NordicSemiconductor/IOS-nRF-Connect-Device-Manager/issues/52

Fabbi commented 1 year ago

fail on line 262 will need this change, too.

Also it sadly doesn't fix #52

dinesharjani commented 1 year ago

Thanks for the fix!