NordicSemiconductor / IOS-nRF-Connect-Device-Manager

A mobile management library for devices supporting nRF Connect Device Manager.
https://www.nordicsemi.com/Software-and-tools/Software/nRF-Connect-SDK
Apache License 2.0
90 stars 41 forks source link

API Change: McuManager setMtu() can now throw, rather than return a Boolean #91

Closed dinesharjani closed 1 year ago

dinesharjani commented 1 year ago

It's possible that setMTU() calls cause an infinite loop. And it's the same small piece of code that happens a couple of times in multiple managers, including the 'echo' command. And instead of patching it in five places, it's better to just make the code express itself better.