search

NordicSemiconductor / IOS-nRF-Connect

Info page
https://nordicsemiconductor.github.io/IOS-nRF-Connect/
136 stars 32 forks source link

URL in Eddystone format not shown correctly #129

Closed ladivin closed 1 year ago

ladivin commented 1 year ago

There's a tiny bug in displaying Eddystone data. The URL is missing the "." sign in front of the domain. Instead of www.zephyrproject.org the application shows www.zephyrprojectorg. Please refer to the attached screenshot.

Source of Eddystone data: Eddystone sample from Zephyr v3.3.0. iOS version: 16.4.1 nRF Connect version: 2.6.3

EddystoneURL

dinesharjani commented 1 year ago

I hear you. I need to check a couple of things and come back to you. Thanks for bringing this up.

dinesharjani commented 1 year ago

You are correct. I wanted to check the hex parsing code properly instead of looking at the internal code mapping. But yes, it was a pretty simple bug. Thanks for pointing this out.

Will ship in version 2.6.4.

ladivin commented 1 year ago

Thank you for taking care of this!

dinesharjani commented 1 year ago

If only everything else was this easy to fix! :)