-:49: WARNING:TYPO_SPELLING: 'attemps' may be misspelled - perhaps 'attempts'?
#49: FILE: Kconfig:22:
+ bool "Reset device when all attemps to reconnect to lte network have been exhausted"
-:418: ERROR:INITIALISED_STATIC: do not initialise statics to 0
#418: FILE: src/main.c:51:
+ static int reconnect_counter = 0;
-:419: WARNING:LINE_SPACING: Missing a blank line after declarations
#419: FILE: src/main.c:52:
+ static int reconnect_counter = 0;
+ switch (evt->type) {
-:440: WARNING:LONG_LINE: line over 80 characters
#440: FILE: src/main.c:73:
+ CONFIG_NAT_TEST_RESET_WHEN_UNABLE_TO_CONNECT)) {
-:662: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#662: FILE: src/nat_cmd.c:1:
+/*
-:665: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#665: FILE: src/nat_cmd.c:4:
+ * SPDX-License-Identifier: LicenseRef-BSD-5-Clause-Nordic
-:722: WARNING:LINE_SPACING: Missing a blank line after declarations
#722: FILE: src/nat_cmd.c:61:
+ struct at_cmd_log *item;
+ item = k_malloc(sizeof(*item));
-:752: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#752: FILE: src/nat_cmd.c:91:
+ return;
+ } else {
-:754: WARNING:LINE_SPACING: Missing a blank line after declarations
#754: FILE: src/nat_cmd.c:93:
+ char *unused;
+ value = strtol(argv[1], &unused, 10);
-:791: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#791: FILE: src/nat_cmd.c:130:
+ return;
+ } else {
-:793: WARNING:LINE_SPACING: Missing a blank line after declarations
#793: FILE: src/nat_cmd.c:132:
+ char *unused;
+ value = strtof(argv[1], &unused);
-:815: WARNING:LINE_SPACING: Missing a blank line after declarations
#815: FILE: src/nat_cmd.c:154:
+ char msg[40];
+ if (!strcmp(argv[-2], "udp")) {
-:831: WARNING:LINE_SPACING: Missing a blank line after declarations
#831: FILE: src/nat_cmd.c:170:
+ enum test_type type;
+ if (!strcmp(argv[0], "udp")) {
-:869: WARNING:LINE_SPACING: Missing a blank line after declarations
#869: FILE: src/nat_cmd.c:208:
+ int err = nat_test_stop();
+ if (err < 0) {
-:890: WARNING:LINE_SPACING: Missing a blank line after declarations
#890: FILE: src/nat_cmd.c:229:
+ int err = set_network_mode(value);
+ if (err == -INVALID_MODE) {
-:1012: WARNING:LINE_SPACING: Missing a blank line after declarations
#1012: FILE: src/nat_cmd.c:351:
+ char *root_obj_string = cJSON_Print(root_obj);
+ if (root_obj_string == NULL) {
-:1074: WARNING:LINE_SPACING: Missing a blank line after declarations
#1074: FILE: src/nat_cmd.c:413:
+ int network_status = get_network_status();
+ while ((network_status != LTE_LC_NW_REG_REGISTERED_HOME) &&
-:1078: WARNING:LONG_LINE_COMMENT: line over 80 characters
#1078: FILE: src/nat_cmd.c:417:
+ /* Trigger a connect attempt only when device can exhaust its reconnect attempts without restarting */
-:1177: WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#1177: FILE: src/nat_cmd.c:516:
+ if (strstr(recv_buf, "error") !=
-:1197: WARNING:INDENTED_LABEL: labels should not be indented
#1197: FILE: src/nat_cmd.c:536:
+ reconnect:
-:1228: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1228: FILE: src/nat_test.c:1:
+/*
-:1231: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#1231: FILE: src/nat_test.c:4:
+ * SPDX-License-Identifier: LicenseRef-BSD-5-Clause-Nordic
-:1342: WARNING:TYPO_SPELLING: 'adresses' may be misspelled - perhaps 'addresses'?
#1342: FILE: src/nat_test.c:115:
+ printk("More than %d adresses found. Remainder will not be added to json\n",
-:1382: WARNING:LINE_SPACING: Missing a blank line after declarations
#1382: FILE: src/nat_test.c:155:
+ char *root_obj_string = cJSON_Print(root_obj);
+ if (root_obj_string == NULL) {
-:1456: WARNING:LINE_SPACING: Missing a blank line after declarations
#1456: FILE: src/nat_test.c:229:
+ int delta = k_uptime_delta(&start_time_ms);
+ per_log_poll_time_ms += delta;
-:1506: WARNING:LONG_LINE_COMMENT: line over 80 characters
#1506: FILE: src/nat_test.c:279:
+ /* Trigger a connect attempt only when device is able exhaust its reconnect attempts without restarting */
-:1586: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1586: FILE: src/nat_test.c:359:
+ return true;
+ } else {
-:1618: ERROR:TRAILING_WHITESPACE: trailing whitespace
#1618: FILE: src/nat_test.c:391:
+ * @brief Run single test case (UDP or TCP). Send data with increasing timeout interval until no answer is received (connection closed due to timeout). $
-:1618: WARNING:LONG_LINE_COMMENT: line over 80 characters
#1618: FILE: src/nat_test.c:391:
+ * @brief Run single test case (UDP or TCP). Send data with increasing timeout interval until no answer is received (connection closed due to timeout).
-:1674: WARNING:INDENTED_LABEL: labels should not be indented
#1674: FILE: src/nat_test.c:447:
+ reconnect:
-:1793: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1793: FILE: src/nat_test.h:1:
+/*
-:1796: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#1796: FILE: src/nat_test.h:4:
+ * SPDX-License-Identifier: LicenseRef-BSD-5-Clause-Nordic
-:1834: ERROR:TRAILING_WHITESPACE: trailing whitespace
#1834: FILE: src/nat_test.h:42:
+ * $
-:1835: WARNING:LONG_LINE_COMMENT: line over 80 characters
#1835: FILE: src/nat_test.h:43:
+ * @param mode New network mode. LTE_LC_SYSTEM_MODE_LTEM = 1 or LTE_LC_SYSTEM_MODE_NB_IOT = 2
-:1851: ERROR:TRAILING_WHITESPACE: trailing whitespace
#1851: FILE: src/nat_test.h:59:
+ * $
- total: 4 errors, 31 warnings, 1823 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
Your patch has style problems, please review.
NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE
NOTE: If any of the errors are false positives, please report
them to the maintainers.
Nits issues
Redundant 'source "$(ZEPHYR_BASE)/Kconfig.zephyr" in 'Kconfig'. Just do 'source "Kconfig.zephyr"'
instead. The $srctree environment variable already points to the Zephyr root,
and all 'source's are relative to it.
Identity/Emails issues
48b4f54485c87d30b47c2b459c4a13b0bf23037c: author email (Markus Tacker Markus.Tacker@NordicSemi.no) needs to match one of the signed-off-by entries.
Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.
Some checks failed. Please fix and resubmit.
checkpatch issues
Nits issues
Identity/Emails issues
48b4f54485c87d30b47c2b459c4a13b0bf23037c: author email (Markus Tacker Markus.Tacker@NordicSemi.no) needs to match one of the signed-off-by entries.
Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.