NordicSemiconductor / NAT-TestFirmware

Used to test NAT timeouts, sends messages to NAT-TestServer
Other
0 stars 0 forks source link

feat: Send AT cmd and result to server #29

Open boundlesscalm opened 4 years ago

boundlesscalm commented 4 years ago

Signed-off-by: Pascal Pickel Pascal.Pickel@nordicsemi.no

github-actions[bot] commented 4 years ago

All checks passed.

checkpatch (informational only, not a failure)

-:298: WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#298: FILE: src/nat_cmd.c:523:
+                       if (strstr(recv_buf, "error") !=

-:318: WARNING:INDENTED_LABEL: labels should not be indented
#318: FILE: src/nat_cmd.c:543:
+   reconnect:

- total: 0 errors, 2 warnings, 379 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPDX_LICENSE_TAG SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

coderbyheart commented 4 years ago

Can you provide a sample JSON of what the code generates?

boundlesscalm commented 4 years ago

@coderbyheart

{
    "op":   "24201",
    "iccid":    "8931089318104314834",
    "imei": "352656100387904",
    "cmd":  "AT+CEREG?",
    "result":   "+CEREG: 5,5,\"76C1\",\"0143F100\",7,,,\"11100000\",\"11100000\"\r\n"
}
jhn-nordic commented 4 years ago

@PascalPickel can you rebase this PR?