search

NordicSemiconductor / NAT-TestFirmware

Used to test NAT timeouts, sends messages to NAT-TestServer
Other
0 stars 0 forks source link

Small fixes #30

Closed boundlesscalm closed 4 years ago

boundlesscalm commented 4 years ago

Unsure about the branch name/squashed commit message. I felt as if these commits were similar enough in objective and small enough to fit into a single commit, though feel free to let me know if this should be changed.

coderbyheart commented 4 years ago

In the future please use separate PRs, especially if there are already existing issue. It makes it easier for reviewers to understand which change addresses which issue, without needing to go through the commits.

coderbyheart commented 4 years ago

How is #14 addressed in this PR?

boundlesscalm commented 4 years ago

That commit was accidentally not added to this pr. Would you prefer it in a different commit or to add it?

coderbyheart commented 4 years ago

Would you prefer it in a different commit or to add it?

Please use a separate PR for the reasons stated above.

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 2.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: