search

NordicSemiconductor / ble-sdk-arduino

MIT License
249 stars 97 forks source link

Additional includes needed when library is used outside of .ino file #13

Closed DEGoodmanWilson closed 5 years ago

DEGoodmanWilson commented 9 years ago

To reproduce: Create a new project with additional .c/.cpp files. Include the BLE library in the project, and copy all those includes to one of the .c files as well. Make calls to the BLE library from that external .c file. Project will fail to compile, complaining of unknown types. These includes get the type definitions in the right place for successful compilation.

There might be a better way to handle this case, but at any rate, this worked for me, and I just thought I'd share.

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Don Goodman-Wilson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

DEGoodmanWilson commented 5 years ago

The email address used for this PR is long dead, thus I have no way of proving I am dgoodman@railstars.com anymore. I'm going to close this PR—anyway, it's five years old! Who knows if this is even a problem anymore.