search

NordicSemiconductor / bluetooth-numbers-database

An up-to-date listing of all the various Bluetooth Specification-related elements that are defined by our industry (Company IDs, Service UUIDs, Characteristic UUIDs and Descriptor UUIDs), that you can use instead of rolling your own.
Other
345 stars 53 forks source link

Add LEGO services and characteristics #48

Closed dlech closed 3 years ago

dlech commented 3 years ago

This adds LEGO-defined service and characteristic UUIDs.

The LEGO WeDo 2.0 UUIDs are defined in the WeDo 2.0 Communication Software Developer Kit and the LEGO Wireless Protocol v3 UUIDs are defined in the LEGO Wireless Protocol 3.0.00 documentation.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

dinesharjani commented 3 years ago

@dlech Hi, I'm very happy to see your contribution. It's very cool! Unfortunately it does not pass our duplicate verification. You can try this for yourself by running npm verify / npm validate locally. Can you check this out?

philips77 commented 3 years ago

The websites you point to define one service and a characteristic: https://lego.github.io/lego-ble-wireless-protocol-docs/#lego-specific-gatt-service and one service and characteristic for the bootloader: https://lego.github.io/lego-ble-wireless-protocol-docs/#lego-bluetooth-hub-boot-loader-service

philips77 commented 3 years ago

The characteristics you added https://github.com/NordicSemiconductor/bluetooth-numbers-database/pull/48/files#diff-cf53d45b4512c145b050e4a71e38cf87e551426d2a9e72fd8eb25fd7cfda4c90R352 as is in fact: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/nrf/include/bluetooth/services/lbs.html#led-button-service-lbs I checked the LEGO SDK and in fact, the UUIDs you have given match those from there. However, LEGO, instead of randomizing the UUID, used the same one as LED Button Service from Nordic. That's actually not recommended, exactly for this reason.

dlech commented 3 years ago

That is unfortunate. Would it be acceptable to still include only the services and characteristics from https://lego.github.io/lego-ble-wireless-protocol-docs? These are the ones with "0000XXXX-1212-EFDE-1623-785FEABCD123" instead of "000XXXX-1212-EFDE-1523-785FEABCD123".