Open LastLockJoe opened 1 month ago
hello @LastLockJoe , thanks for reaching out.
Looks like we have updated default configuration settings for the COMP driver but missed the doc alignment. 1.2 V reference voltage was chosen specifically as it is a common denominator across all nRF devices.
We will update the doc in next release
I was looking at the default configuration for the comparator and I noticed that the reference voltage in the comment does not match the reference voltage in the code.
Given the default threshold configuration uses 1.8, I assume the reference voltage should be changed to NRF_COMP_REF_INT_1V8.
From my understanding of the comparator peripheral, setting the default internal ref to 1V8 would result in the comparator not working properly for boards with VDD = 1V8, ex: nRF7002 DK. Perhaps a warning should be added to note this?