search

NordicSemiconductor / pc-ble-driver-js

Node.js interface to the C/C++ pc-ble-driver library. API docs: https://nordicsemiconductor.github.io/pc-ble-driver-js/
Other
79 stars 41 forks source link

Upgrade nrf-device-lister dependency #245

Closed datenreisender closed 4 years ago

datenreisender commented 4 years ago

Part of NCP-2996.

This brings along the upgraded serialport dependency, which renames the property comName to path.

From my limited understanding of the pc-ble-driver-js project, this project partially contains copies of the serialport code, so we might not have update the property here, but still it seems to me, that it would be good to stay in sync.

Is this correct?

Also: I did not understand, whether this project does expose the comName to other code using this project. Do we have to duck tape the old property, so that we do not break other code?