search

NordicSemiconductor / pc-ble-driver-js

Node.js interface to the C/C++ pc-ble-driver library. API docs: https://nordicsemiconductor.github.io/pc-ble-driver-js/
Other
79 stars 41 forks source link

Fix incorrect parsing of Out-Of-Band data #287

Open dordnung opened 2 years ago

dordnung commented 2 years ago

Inputting Out-Of-Band data will never be possible, as the input is not parsed as hex string put every char in the hex string will be converted to its ascii representation thus also only considering the first 8 bytes.

There are some reports considering this issue: https://devzone.nordicsemi.com/f/nordic-q-a/47932/oob-works-with-mcp-but-fails-with-nrf-connect https://devzone.nordicsemi.com/f/nordic-q-a/16693/error-oob-static-key-nrf-connect

This pull request will fix this by converting every hex byte in the hex string as byte.

182859693-9552eb1c-09a9-4e22-9898-8e8a4a747bab

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.