NordicSemiconductor / pc-ble-driver-py

Python bindings for the ble-driver library
Other
126 stars 115 forks source link

Fixed error handling for NRF_ERROR_RESOURCES #139

Closed sorceressofmathematics closed 4 years ago

sorceressofmathematics commented 4 years ago

Whenever a NRF_ERROR_RESOURCES was encountered, the error-handling code in the BLEAdapter was searching for the string "Error code: 19" even though this string is no longer contained within the exception. Because of this, these were never getting handled and the program simply crashed instead, including when using nrfutil's DFU functionality. I've fixed the code in question so it should be handling these errors correctly again.

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Lexi Linnell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

bihanssen commented 4 years ago

@sorceressofmathematics thanks for reporting and providing a PR. If you sign the CLA we can merge it in.

sorceressofmathematics commented 4 years ago

Just signed it, thanks.

bihanssen commented 4 years ago

@sorceressofmathematics CLAassistant seems to complain about CLA signing still.