Closed dangu closed 3 years ago
@dangu thanks for the PR. I think your proposed solution looks sound.
Oh, I see now that "master" has been merged into "feature/conn_sec_mode". Is this really the way to do this? This means I need to take care to not break anything if I push a fix for the above review comments, right?
Edit: Tried pushing a fix for the above comments.
@dangu, merging master into this branch is no problem. It’s anyway required before eventually merging into master.
@dangu I added some changes to the PR. Will merge this to master now.
When trying to read a characteristic I was getting READ_NOT_PERMITTED. I would like to discuss how to add the functionality of BLE_GAP_CONN_SEC_MODE_SET_OPEN() and friends to pc_ble_driver_py, to control the read_perm and write_perm of BLEGattsAttrMD.
I have made some tests with adding this line to BLEGattsAttrMD:
After that, it is possible to assign the sm and lv properties:
I also started implementing a class BLEGapConnSecMode for the ble_gap_conn_sec_mode_t but now I need help. How do I proceed?
Edit: Ok, I think I start to understand the structure of this. What do you think about my suggested set_no_access() and set_open() methods in BLEGapConnSecMode? Is this the way to go? This allows for this kind of code: