Closed kylebonnici closed 2 months ago
@datenreisender after further testing the / 100 was not needed. the issue is that mtimeMs give a decimal and comparing two decimal will not guarantee === due to floating point errors. rounding solves the issues
For what bug/use case do we need to check that the time stamps in the used and bundled
nrfutil
are the same?I expected the check to be “if the bundled version is newer” but it is more like “if the bundled version is different”. Is there a case, where we might want to overwrite with an older version?
I assume when we run
nrfutil self-upgrade
, the time stamps do not get overwritten?BTW: Is
fs-extra
needed for these operations? Nowadaysfs-extra
seems mostly like an unneeded dependency, so I would like to move away from it, but this doesn't have a high priority for me.
re fs-exter we can move away, I did not pay attention to which one I used to be honest. re self-upgrade will update the core in the sandbox and not the wrapper we ship so no self-upgrade will not overwrite the nrfutil we bundle re check we can overwrite if the one on disk is older and not different :)
Add labels:
'doc required' or 'doc not required'
For UI review: