search

NordicSemiconductor / zcbor

Low footprint C/C++ CBOR library and Python tool providing code generation from CDDL descriptions.
Apache License 2.0
105 stars 34 forks source link

include: Remove zcbor_simple_*() functions from the header file #397

Closed oyvindronningstad closed 2 months ago

oyvindronningstad commented 5 months ago

To avoid using it in favor of bool/nil/undefined.

sigvartmh commented 5 months ago

Just reading the note it's a bit unclear to me why it shouldn't be used. Why is this function exposed if it shouldn't be used?

oyvindronningstad commented 5 months ago

I understand. Two reasons: 1) for completeness, and 2) for future proofing, in case the CBOR spec adds new uses for them without it being propagated to the zcbor code. None of the reasons are particularly strong, so maybe I should remove the API instead.

oyvindronningstad commented 4 months ago

I removed them from the header file, but kept the implementations as non-static so they can theoretically be accessed if needed.