search

Nordstrom / artillery-plugin-influxdb

Plugin for Artillery.IO that records response data into InfluxDB.
Apache License 2.0
8 stars 12 forks source link

Added user concurrency metric #12

Closed bsliran closed 6 years ago

bsliran commented 7 years ago

user concurrency metric is now reported to the influx db

erikerikson commented 7 years ago

Thank you for the contribution @bsliran !

My first thought is whether this represents the second of a number of such requests (see also https://github.com/Nordstrom/artillery-plugin-influxdb/pull/10/files). Is there a means to do this in a more generalized way @gwsii ? Perhaps using JSON path? Something that PR implements that this one does not is conditional inclusion of the metric.

erikerikson commented 7 years ago

BTW - is it best practice to add a separate data point/row per metric or does adding the new metric as an attribute of the existing point make more sense? I was just looking at that prior PR/expansion to the reported metrics and it appears (as commented) to have room for improvement but the approach taken should probably be consistent between that PR and this one.

gwsii commented 7 years ago

@bsliran We're hoping that our latest feature, Custom Measurements, will enable you to capture this data from the Artillery report and write it to InfluxDB. Please have a look a feel free to download the branch and see if you can define a measurement that gets you what you need.

Thanks! ~Greg