search

Nordstrom / artillery-plugin-influxdb

Plugin for Artillery.IO that records response data into InfluxDB.
Apache License 2.0
8 stars 12 forks source link

Adds work-around for shift in reporting schema on 'stats' event from artillery-core. #7

Closed gwsii closed 8 years ago

gwsii commented 8 years ago

This is a fix for issue #6 not 3. LOLs.

@erikerikson can you have a look, please? Seems like this'll block the workshop. TY!

gwsii commented 8 years ago

Looks like this was the artillery-core commit that did it: https://github.com/shoreditch-ops/artillery-core/commit/e6ad605d88e81a3f132e13c30e4aacfcd9729748#diff-b3b53682a18f203ac8d29b0e277cad26

erikerikson commented 8 years ago

I think you've exactly identified the commit that created the plugin integration break for the intermediate 'stats' event.

This is a bit of a messy situation. Hassy and I were discussing it here: https://github.com/shoreditch-ops/artillery/issues/193

The core problem is that plugins don't have a mechanism for declaring compatibility or customizing the integration to target the version of artillery that they were loaded by. I would prefer a more cleanly separated handling of the different artillery versions but given deadlines, if this is tested to work, I'm happy to move forward with a merge, create an issue to go back and clean up, and deal with it when there's a bit more slack and/or a solution to the core problem.

gwsii commented 8 years ago

Thanks, Erik. Seems like this change should hold us until artillery-core@^3, so going to merge. Will open an issue to adopt whatever contract that artillery-core comes up with.