Nordstrom / serverless-attach-managed-policy

Attaches the provided ManagedPolicyARN to all Roles in the service.
Apache License 2.0
11 stars 8 forks source link

Enabled AWS managed policy. #3

Closed otakumesi closed 6 years ago

otakumesi commented 6 years ago

What did you implement:

Enable AWS managed policy.

https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_managed-vs-inline.html#aws-managed-policies

How did you implement it:

AWS managed policy's ARN format is arn:aws:iam::aws:policy/{{ROLE_NAME}}. But, This format is ServerlessPlugin#verifyConfig() is not acceptable. So, I touch up.

erikerikson commented 6 years ago

Thanks for this @otakumesi.

Looks good to me at a glance but I'll defer to @gwsii for the merge and publish.

gwsii commented 6 years ago

mergeは日本語で何ですか。知らない。でも僕たちわします。ありがとう!

otakumesi commented 6 years ago

@erikerikson @gwsii Thank you, too!!!

Japanese software developers also call "merge" merge. So, "merge" make sense.