Fix http2 and metrics - Githubissues

Nordstrom / xrpc

Simple, production ready Java API server built on top of functional composition.

Apache License 2.0

17 stars 17 forks source link

Fix http2 and metrics #174

Closed andyday closed 6 years ago

andyday commented 6 years ago

Fixes #172

Fix broken http2 access for demos/people. NullPointer exception in Http2CorsHandler.
Fix /metrics access for demos/people. We were passing the MetricsModule not MetricsRegistry to encoding.
Add alpn support for OkHttp for testing http2.
Add sanity unit tests for metrics.
Changed AdminHandlers to use ResponseFactory methods.
Added pretty option to Encoder - for use with current AdminHandlers.
Upgraded gradle to 4.6 - part of attempt to get alpn working.

andyday commented 6 years ago

@jkinkead i removed the pretty encoding. i had originally thought to go that way but added it in anyway. much cleaner with it gone. all other comments have been addressed also.

andyday commented 6 years ago

on the validateOrigin, if its doing something with the class member variable, i see no reason to pass it in as an argument other than to achieve some sort of functional purity.

andyday commented 6 years ago

@jkinkead i've addressed these last comments.