Firewall effectively does nothing - Githubissues

Nordstrom / xrpc

Simple, production ready Java API server built on top of functional composition.

Apache License 2.0

17 stars 17 forks source link

Firewall effectively does nothing #205

Open manimaul opened 6 years ago

manimaul commented 6 years ago

Summary

The Firewall does not actually do anything and is effectively a noop channel handler.

Steps to reproduce

Created an EmbeddedChannel with BlackListFilter and Firewall channel handlers.
Make a request with a black listed ip.

Expected behavior

The channel should be closed with no response.

Actual behavior

Nothing actually happens - the channel is still active and open.

Minimal yet complete reproducer code (or URL to code)

https://github.com/Nordstrom/xrpc/blob/1fe8c8a299211bbe687b4414d8aa2c0096b194c6/xrpc/src/main/java/com/nordstrom/xrpc/server/Firewall.java#L48-L63

xrpc version

0.1.0