search

NorfairKing / feedback

Declarative feedback loop manager
https://cs-syd.eu/posts/2022-11-14-automate-your-feedback-loops-using-feedback
GNU General Public License v3.0
61 stars 10 forks source link

Add support for Darwin #15

Open kalhauge opened 1 year ago

kalhauge commented 1 year ago

This pull request adds support for Darwin. While the changes seem dramatic, it only adds a function wrapper around the file so that a system can be chosen, and then recursive merges the Linux and Darwin versions.

kalhauge commented 1 year ago

The pull request looks a little formal, sorry about that. Great work with the tool! I wanted to check it out, but it did not work on my machine (MacOS). It turned out that the changes needed to make it work was minimal :).

srid commented 1 year ago

@kalhauge You could look into making haskellPackages.feedback build (it doesn't on M1 mac) on https://github.com/NixOS/nixpkgs and even add a top-level package like maralorn did with https://github.com/NixOS/nixpkgs/pull/199442) so that users can simply run nix run nixpkgs#feedback.

This way, this repo doesn't have to support macOS, but at least nixpkgs can.

kalhauge commented 1 year ago

As indicated in #14, @NorfairKing does not have the resources to maintain a darwin version of the tool. He have agreed to keep the pull-request open so that people can see the current progress and possibly attract maintainers.

For now if have an Intel Mac you can use my fork instead: 

> nix run github:kalhauge/feedback

@srid I don't have an M1 Mac, but try if it does not just work with the modifications on my branch.