kill signal for server process in `loop`

peterbecich commented 8 months ago

Thanks for this great program.

It runs a program halogen-chess which binds to port 8080.

The loop runs once successfully. When the loop restarts, I see an error:

halogen-chess: Network.Socket.bind: resource busy (Address already in use)

The issue is solved by exiting feedback, which kills the halogen-chess process bound to port 8080.

Could feedback send a different kill signal to the process, when the loop is repeated, to solve this issue?

An alternative solution may be a before-all hook, such as:

    hooks:
      before-all:
        kill -9 $(lsof -t -i:8080 -sTCP:LISTEN);

NorfairKing commented 8 months ago

@peterbecich Feedback was never really intended for long-running processes in the loop, but now I see that that's actually a really cool use-case.

I think your before-all hook would not really solve the issue at hand.

Feedback "just" needs to wait for the process to exit correctly, but I'm surprised that it doesn't because I thought I had implemented that :(

Any digging would be welcome because I'm currently at an airport.

NorfairKing commented 7 months ago

@peterbecich any news?

peterbecich commented 5 months ago

@NorfairKing , no, sorry, I've been unable to put any time into this issue

NorfairKing commented 5 months ago

@peterbecich have you tried with latest master? It might be fixed now. I added some smartness about killing the loop process.

NorfairKing / feedback