search

NorfairKing / smos

A comprehensive self-management System
https://smos.online
MIT License
294 stars 48 forks source link

Do not open the firewall by default #274

Closed prescientmoon closed 9 months ago

prescientmoon commented 9 months ago

This mirrors the recent intray change

prescientmoon commented 9 months ago

I added an additional commit, as the module was failing when the api-server was given no hosts.

NorfairKing commented 9 months ago

@Mateiadrielrafael In general we need nix flake check to pass before merging anything, and a changelog entry. Unfortunately I think that might involve more ceremony than we'd like, because we'd need a forward-compatible release in order for that to work. I'm open to turning off e2e-test-forward-compatibility for this release.

What do you think?

prescientmoon commented 9 months ago

@NorfairKing Would forward compatibility be restored by simply making the openFirewall option on by default?

NorfairKing commented 9 months ago

@Mateiadrielrafael Yes, that's an option. Then we need another commit for the next release to set that default to false.

prescientmoon commented 9 months ago

@NorfairKing Sure, that's fine.

NorfairKing commented 9 months ago

@Mateiadrielrafael I'll push a commit in a moment. One moment.

NorfairKing commented 9 months ago

@Mateiadrielrafael Please see the firewall branch.

prescientmoon commented 9 months ago

@Mateiadrielrafael Please see the firewall branch.

Yep, that looks good!

NorfairKing commented 9 months ago

I just released a new version with this change, and the next release will have the default be false.