search

NorfairKing / sydtest

A modern testing framework for Haskell with good defaults and advanced testing features.
113 stars 25 forks source link

add a `shouldMatchList` combinator #56

Closed temyurchenko closed 1 year ago

temyurchenko commented 2 years ago

The motivation for adding it is that it's present in the hspec-expectations library and is occasionaly useful

NorfairKing commented 2 years ago

Excellent! Before I merge:

  1. Don't forget to export this function at the top level as well.
  2. Add a changelog entry.
  3. Bump the version so I can release after merging.
  4. Double-check that CI passes.
  5. Make sure you know what the license says and agree with it.
temyurchenko commented 2 years ago

Excellent! Before I merge:

1. Don't forget to export this function at the top level as well.

2. Add a changelog entry.

3. Bump the version so I can release after merging.

4. Double-check that CI passes.

5. Make sure you know what the license says and agree with it.

Done, with the exception of CI, need approval once more. But the previous CI check did pass

NorfairKing commented 2 years ago

@murcake I think we're in the clear here, given that @sol has no stance against this inclusion and we're bound to end up with a similar API anyway. I'm happy to merge, how about you?

temyurchenko commented 1 year ago

@murcake I think we're in the clear here, given that @sol has no stance against this inclusion and we're bound to end up with a similar API anyway. I'm happy to merge, how about you?

I don't have objections

NorfairKing commented 1 year ago

Merged and released.