NorfairKing / sydtest

A modern testing framework for Haskell with good defaults and advanced testing features.
113 stars 25 forks source link

Add support for multiple filter flags #63

Closed mrcjkb closed 1 year ago

mrcjkb commented 1 year ago

Fixes #62.

I tested this manually, but it might make sense to add a test suite (?)

Not sure where though. I couldn't find any existing tests for the argument parsing.

NorfairKing commented 1 year ago

This looks like it's exactly what I wanted. I'll try it out and merge when CI passes.

mrcjkb commented 1 year ago

Perfect. Let me know when you publish a release, and then I'll merge the sydtest support for neotest-haskell, which is pretty much ready, too 😄

NorfairKing commented 1 year ago

@mrcjkb Excellent. I will release today. Just to be sure: please confirm that you accept the licence.

mrcjkb commented 1 year ago

Yes, I do :smile:

NorfairKing commented 1 year ago

Merged manually and released as sydtest-0.13.0.4.

mrcjkb commented 1 year ago

Also, to confirm: After the merge, neotest-haskell will use sydtest fixtures in its test suite. The plugin is licensed under GPLv2.0, so this is in line with sydtest's usage conditions, right?

I have added a copy of the license to the fixtures: https://github.com/mrcjkb/neotest-haskell/pull/73/commits/85917cd4101fc053b4537325e52f5202fb92f4d1

NorfairKing commented 1 year ago

@mrcjkb jup that's fine :)