NorfairKing / sydtest

A modern testing framework for Haskell with good defaults and advanced testing features.
113 stars 25 forks source link

incompatibility with optparse-applicative 0.18.0.0 #71

Closed locallycompact closed 11 months ago

locallycompact commented 1 year ago
error: builder for '/nix/store/dcxiyy28ni9acarb7l1s5lj6zidgc8jq-sydtest-0.15.0.0.drv' failed with exit code 1;
       last 10 log lines:
       > [ 5 of 28] Compiling Test.Syd.OptParse ( src/Test/Syd/OptParse.hs, dist/build/Test/Syd/OptParse.o, dist/build/Test/Syd/OptParse.dyn_o )
       >
       > src/Test/Syd/OptParse.hs:21:56: error: [GHC-61689]
       >     Module ‘Options.Applicative.Help’ does not export ‘string’.
       >    |
       > 21 | import qualified Options.Applicative.Help as OptParse (string)
       >    |                                                        ^^^^^^
       > [ 6 of 28] Compiling Test.Syd.Expectation ( src/Test/Syd/Expectation.hs, dist/build/Test/Syd/Expectation.o, dist/build/Test/Syd/Expectation.dyn_o )

via

https://gitlab.horizon-haskell.net/package-sets/horizon-core/-/jobs/375201

arguri commented 1 year ago

@locallycompact string has been renamned to pretty. @NorfairKing What is your stance on CPP or a possible fix? Would you rather have the version of optparse-applicative to be fixed for 0.15.1.1 or try to use the same fix @locallycompact used with PR-69. (On a sidenote, I think your CONTRIBUTING.md needs a little update or a hint more details, as nix-shell fails with missing default.nix)

NorfairKing commented 1 year ago

@arguri sad that optparse-applicative wasn't backward compatible this way, but oh well.

I have no problem with CPP. The build just has to keep passing with the current and past three nixos releases: https://github.com/NorfairKing/sydtest/blob/a3ba5f3096c3dcc58920f61ba8a45191d9020eb4/flake.nix#L16-L18 I also don't feel comfortable merging anything untested and I only test with the latest (four) stable nixos releases.

(On a sidenote, I think your CONTRIBUTING.md needs a little update or a hint more details, as nix-shell fails with missing default.nix)

Yes nowadays it's nix develop or direnv allow, PR welcome.

NorfairKing commented 11 months ago

Should be fixed now.