Add GHC 9.2 support - Githubissues

NorfairKing / validity

Validity and validity-based testing

https://www.youtube.com/watch?v=eIs9qNh17SM

MIT License

156 stars 31 forks source link

Add GHC 9.2 support #100

Closed srid closed 2 years ago

srid commented 2 years ago

Sized Word/Int changes: https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.2#sized-wordint-use-sized-wordint-primitives
Aeson 2's KeyMap/Key types are new: https://github.com/haskell/aeson/issues/881#issuecomment-944920664 (also resolves #99)
Use https://github.com/yesodweb/persistent/pull/1338

srid commented 2 years ago

I don't know if I got the instances right.

NorfairKing commented 2 years ago

The instances look right to me!

ocharles commented 2 years ago

Hi all, any chance of this being merged and released? It's preventing me from using ghc-debug-brick, as that depends on cursor which depends on validity.

NorfairKing commented 2 years ago

@ocharles I cannot put this in CI yet because there's no nixpkgs version that uses GHC 9.2 yet, but I could "hope" that it just works and release anyway. Soonest would be monday though.

ocharles commented 2 years ago

Fair enough. Haskell.nix has 9.2.2, though that's a bit of extra work

srid commented 2 years ago

nixpkgs has 9.2.1 - but not as default (things may not be cached):

❯ nix-env -f "<nixpkgs>" -qaP -A haskell.compiler | grep -E '(921|9\.2\.1)' | grep -v integer
haskell.compiler.ghc921                  ghc-9.2.1

NorfairKing commented 2 years ago

More or less to be expected: this doesn't build (with --pedantic) or pass tests (infinite loop in genvalidity-aeson). I'll see what I can do.

These need to pass before I can merge:

stack test --pedantic --bench --no-run-benchmarks --no-rerun-tests
stack test --pedantic --bench --no-run-benchmarks --no-rerun-tests --stack-yaml stack-9.2.1.yaml
nix-build ci.nix

NorfairKing commented 2 years ago

In particular stack test genvalidity-aeson currently hangs for GHC 9.2.1 but not the current version.

Bodigrim commented 2 years ago

As a Hackage trustee I made necessary revisions to prohibit invalid build plans:

srid commented 2 years ago

@NorfairKing Everything should be fixed now.

(nix-build ci.nix did run successfully, IIRC, but it is not using GHC 9 I think)

srid commented 2 years ago

64a9450

This was a self-own. Just because it got compiled doesn't mean it was correct.

NorfairKing commented 2 years ago

Merged as part of #104 , ty!