Closed srid closed 2 years ago
I don't know if I got the instances right.
The instances look right to me!
Hi all, any chance of this being merged and released? It's preventing me from using ghc-debug-brick
, as that depends on cursor
which depends on validity
.
@ocharles I cannot put this in CI yet because there's no nixpkgs version that uses GHC 9.2 yet, but I could "hope" that it just works and release anyway. Soonest would be monday though.
Fair enough. Haskell.nix has 9.2.2, though that's a bit of extra work
nixpkgs has 9.2.1 - but not as default (things may not be cached):
❯ nix-env -f "<nixpkgs>" -qaP -A haskell.compiler | grep -E '(921|9\.2\.1)' | grep -v integer
haskell.compiler.ghc921 ghc-9.2.1
More or less to be expected: this doesn't build (with --pedantic
) or pass tests (infinite loop in genvalidity-aeson
). I'll see what I can do.
These need to pass before I can merge:
stack test --pedantic --bench --no-run-benchmarks --no-rerun-tests
stack test --pedantic --bench --no-run-benchmarks --no-rerun-tests --stack-yaml stack-9.2.1.yaml
nix-build ci.nix
In particular stack test genvalidity-aeson
currently hangs for GHC 9.2.1 but not the current version.
As a Hackage trustee I made necessary revisions to prohibit invalid build plans:
https://hackage.haskell.org/package/validity-0.12.0.0/revisions/ https://hackage.haskell.org/package/validity-0.11.0.1/revisions/ https://hackage.haskell.org/package/validity-0.11.0.0/revisions/ https://hackage.haskell.org/package/validity-0.10.0.0/revisions/ https://hackage.haskell.org/package/validity-0.4.0.0/revisions/ https://hackage.haskell.org/package/validity-0.4.0.1/revisions/ https://hackage.haskell.org/package/validity-0.4.0.2/revisions/ https://hackage.haskell.org/package/validity-0.4.0.3/revisions/ https://hackage.haskell.org/package/validity-0.4.0.4/revisions/
@NorfairKing Everything should be fixed now.
(nix-build ci.nix
did run successfully, IIRC, but it is not using GHC 9 I think)
This was a self-own. Just because it got compiled doesn't mean it was correct.
Merged as part of #104 , ty!