search

NorfairKing / validity

Validity and validity-based testing
https://www.youtube.com/watch?v=eIs9qNh17SM
MIT License
156 stars 31 forks source link

Create validity and genvalidity packages for 'dlist' #120

Closed clintonmead closed 2 months ago

clintonmead commented 2 months ago

In preparation for adding instances to autodocodec for DList and DNonEmpty

NorfairKing commented 2 months ago

Nice! I'll start using these for my Validations! Building now, will merge in a moment.

NorfairKing commented 2 months ago

I'm ready to merge and release @clintonmead , are you ready?

clintonmead commented 2 months ago

@NorfairKing hold up sorry I shouldn't have opened this PR so soon. Something is causing Data.DList.DNonEmpty.fromList: empty list in the autodocodec tests so I've mucked up the generator for DNonEmpty.

clintonmead commented 2 months ago

@NorfairKing okay we're good now :)

clintonmead commented 2 months ago

@NorfairKing see https://github.com/NorfairKing/autodocodec/pull/55 for the autodocodec PR

NorfairKing commented 2 months ago

Merged manually and released.

clintonmead commented 2 months ago

@NorfairKing the commit you need to merge is https://github.com/NorfairKing/validity/commit/ae3cc278864f27631eab3aabbbacd26890ce09c2 but I think you've merged https://github.com/NorfairKing/validity/commit/c0c44a6f29e4b13811da2240682e09e53e342e47.

https://github.com/NorfairKing/validity/blob/master/genvalidity-dlist/src/Data/GenValidity/DNonEmpty.hs in master is different to in this PR: https://github.com/clintonmead/validity/blob/ae3cc278864f27631eab3aabbbacd26890ce09c2/genvalidity-dlist/src/Data/GenValidity/DNonEmpty.hs

NorfairKing commented 2 months ago

@clintonmead oh shoot :(

NorfairKing commented 2 months ago

@clintonmead I think I did it right this time.