search

Norfeldt / github-issue-reactions-browser-extension

List a link of reactions on a github issue page
MIT License
50 stars 10 forks source link

Scroll support? #30

Open saiworksandbox opened 1 year ago

saiworksandbox commented 1 year ago

When there are a lot of reactions the list view gets cut off. And the rest can be viewed only at the bottom of the page. Screenshot (2) It would be great if we could scroll through this. Thank you for such a useful extension 👌

Norfeldt commented 1 year ago

The problem is that it is "sticky" and I'm wondering if you would be better off with a filter/threshold (top x most rated reactions)?

saiworksandbox commented 1 year ago

what are your thoughts on having pages? with arrow icons for navigation. Often times I find myself looking for reactions (even if few) on the bottom of the page as that's where the latest info is. Filtering is certainly a cleaner solution though.

Norfeldt commented 1 year ago

I never personally had the problem. If I did then I would just toggle the layout from block(s) to inline.

Jul-19-2023 20-36-24

I'm not saying that it not a real problem. I want to find the correct solution to the problem before jumping into the code.

Norfeldt commented 1 year ago

a hack would be update the .reaction-wrapper to include:

height: 85vh;
overflow: auto;

It just feels like it messes with the page scroll since it common to place your cursor above the reactions and start scrolling.

saiworksandbox commented 1 year ago

Its certainly an edge case when even the inline mode gets cut off. Maybe a toggle to reverse the order of the reactions? so that reactions on the latest comments show up first?

Norfeldt commented 1 year ago

Or have a toggle for the position: sticky 😉

I suggest you either make a PR. Otherwise I will wait to see if this issue gets some 👍 from other users and then make the feature.