search

Norfeldt / github-issue-reactions-browser-extension

List a link of reactions on a github issue page
MIT License
50 stars 10 forks source link

Works in Brave? #7

Closed danawoodman closed 3 years ago

danawoodman commented 3 years ago

I've followed the Chrome extensions in the Brave browser but am not seeing the extension even after reloading

image

I've restarted Brave and reloaded the extension.

I've also disabled "shields" for Github.com.

EDIT: Noticed this, which seems wrong?

image

Norfeldt commented 3 years ago

I don't have any experience with Brave. But browsing on the topic I saw that it can install chrome extensions from the chrome webstore - so it should be able to work.

What errors shows when you click the errors button?

It could be something with a missing manifest - which states what this extension needs access to.

danawoodman commented 3 years ago

@Norfeldt thanks for the reply, actually it was this line:

header.style = `position: relative;height: 100%;`;

Which I fixed by turning into a string but it's still not loading properly. I'll try to debug it a bit more myself and report back 👍

danawoodman commented 3 years ago

Ah, i think I assumed it also works for Pull Request which is what I was viewing. Issues do seem to work 😄 Maybe I'll submit a PR for PR support 😉

danawoodman commented 3 years ago

Added PR #8 to add Pull Request support and a few other tweaks

Norfeldt commented 3 years ago

I have merged #8 - thank you

danawoodman commented 3 years ago

Thank you @Norfeldt for the extension and the merge!