Closed JakubKubista closed 4 years ago
I am not entirely understanding the purpose of this, could you please explain it a bit more?
Never mind, if I understand it correctly you want to be able to throttle individual keypresses too.
I agree that the wording is not very clear. Also this new feature needs to be mentioned in README docs. The naming for this param should be something prefixed by “is” to make it intuitive that it is a bool, but something different from the current name. Let’s think about it tomorrow 🙂
.. param should be something prefixed by “is” ..
I was going to suggest the same, but then I noticed we already have these:
this.enabled = false;
this.nativeMode = false;
this.paused = false;
this.debug = false;
But I think the linting rule usually prefers is* / has* as you said, so I guess that's the way to go. 👍
Oh, I didn’t check old flags names, indeed we don’t really follow this rule. But still, we should name it somehow differently. Hardest part..
Ok, I think throttleKeypresses
sounds good. It means that it throttles all key presses, and not only press Down like it was by default.
And please also update README about this new flag.
Issue
Changed
throttleKeypresses
to prevent canceling of throttled events for individual key presses