Closed denjello closed 9 years ago
Hi @denjello, you have some nice work here! Good catch with skip-rebase
in particular, that makes a lot of sense. However, I think you really should have split this up into several commits so that it would be easier to track each functional change where possible. For example, I'm not sure if I want to change all the example files to point to the minified versions, since I like to use them during development. Also, changing 0px
to 0
is a stylistic change that does not affect functionality and shouldn't be combined with a functional change.
If you could rebase this commit into several commits, it would be easier to track the changes and pull in the best bits.
Sorry, with no response for so long and the code base having moved on with some of the issues being fixed independently, this PR is being closed. :no_entry_sign:
This may seem like a lot of changes, but I really only wanted to fix the fact that the .min.css in the dist folder looked like this:
background-image: url("../dist/images/toggle.svg");
and I neither wanted to pollute my app's folder structure nor hard-code changes post-bower install. What I wanted was this:
background-image: url("../images/toggle.svg");
Changes
--skip-rebase
tobuild:css
in package.json