feat: add IP Address Field

Normal-OJ / new-front-end

v2 client for Normal Online Judge

https://noj.tw

Mozilla Public License 2.0

0 stars 7 forks source link

feat: add IP Address Field #149

Closed aokblast closed 7 months ago

aokblast commented 7 months ago

This patch add IPAddress Field on Submission Pages as BackEnd have this change.

cloudflare-pages[bot] commented 7 months ago

Deploying with Cloudflare Pages

Latest commit:	`c15a5dd`
Status:	✅ Deploy successful!
Preview URL:	https://c551f951.nfe.pages.dev
Branch Preview URL:	https://feat-ipaddressfield.nfe.pages.dev

View logs

uier commented 7 months ago

Hi @aokblast, the changes look good to me, only one question, does the IP Address need to be displayed for every users?

Or it's mainly for TA & instructor? In this case, it would be better to only show the IP Address for admin users by adding v-if="session.isAdmin" on <td> and <th>. Because the table has too many columns and seems clutter.

uier commented 7 months ago

oh, another question, you may also wanna add this ip column in src/pages/course/[name]/submissions/[id].vue? This page component is used for page displaying single submission details.