search

Nornec / Midinous-Issues

2 stars 0 forks source link

1.0.5 Error dialog is thrown when repeatedly performing a play operation with a start point configured #8

Closed worblyhead closed 1 year ago

worblyhead commented 1 year ago

In the 1.0.5 Beta I was going through the various steps of the initial tutorial when I got an error dialog for performing Play operations (I was using the spacebar to initiate play). In this case there is indeed a Start point configured.

1) Open Midinous Beta 1.0.5 and start the tutorial

2) Scroll to the part of the tutorial discussing Start points

3) Repeatedly hit spacebar (or Play control) and notice that every once in awhile an error dialog is thrown (please seen attached screencap) .

Not sure if this is timing event/control focus related or not. Pressing the spacebar works most of the time, though every once in awhile the error dialog is thrown.

Midinous_StartBehavior_1
worblyhead commented 1 year ago

The more I try to reproduce this the more it appears to be simply a timing issue. If play is repeated faster than some delta t than the dialog results. I tried to use just 1 Midi primary start point and extend the duration value and couldn't get the issue to reproduce.

Nornec commented 1 year ago

This is an interesting one -- it may be a race condition between tasks. I'll look into this and debug appropriately.

Nornec commented 1 year ago

I cannot reproduce this. The error may have been related to the object ID bug that was causing crashes before. In the next release, we will have to see if this still happens.

worblyhead commented 1 year ago

I just updated to Beta 1.1.0 and this issue persists. I simply placed a start MIDI point and consecutively hit the space bar to initiate play over and over again. Didn't take too many clicks to get the error dialog to be thrown.

Nornec commented 1 year ago

That's very strange. I was mashing play and space for a few minutes yesterday in multiple files without getting your error message. What is your system info? This may call for a screenshare or a video so i can see it in action

On Wed, Oct 19, 2022, 07:57 worblyhead @.***> wrote:

I just updated to Beta 1.1.0 and this issue persists. I simply placed a start MIDI point and consecutively hit the space bar to initiate play over and over again. Didn't take too many clicks to get the error dialog to be thrown.

— Reply to this email directly, view it on GitHub https://github.com/Nornec/Midinous-Issues/issues/8#issuecomment-1283894596, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQ2UVQ57XRVX5F3Y7H6AOTWD7OYZANCNFSM6AAAAAAREXWZAA . You are receiving this because you modified the open/close state.Message ID: @.***>

worblyhead commented 1 year ago

[image: image.png]

On Wed, Oct 19, 2022 at 8:47 AM Jay @.***> wrote:

That's very strange. I was mashing play and space for a few minutes yesterday in multiple files without getting your error message. What is your system info? This may call for a screenshare or a video so i can see it in action

On Wed, Oct 19, 2022, 07:57 worblyhead @.***> wrote:

I just updated to Beta 1.1.0 and this issue persists. I simply placed a start MIDI point and consecutively hit the space bar to initiate play over and over again. Didn't take too many clicks to get the error dialog to be thrown.

— Reply to this email directly, view it on GitHub < https://github.com/Nornec/Midinous-Issues/issues/8#issuecomment-1283894596 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AFQ2UVQ57XRVX5F3Y7H6AOTWD7OYZANCNFSM6AAAAAAREXWZAA

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Nornec/Midinous-Issues/issues/8#issuecomment-1283961592, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3TAYAAICDNSMYJUAXGARFDWD7UWXANCNFSM6AAAAAAREXWZAA . You are receiving this because you authored the thread.Message ID: @.***>

Nornec commented 1 year ago

I don't think your image upload worked. But a video would be better

worblyhead commented 1 year ago

image

worblyhead commented 1 year ago

I'll try to get a video of some sort together later tonight.

worblyhead commented 1 year ago

One other thing. I went through changing the Duration value of the start point as in the screenshot below. A value of 1.5 almost immediately gets the dialog to appear more so than any other value that I tried. For the default value of 1, you can get the behavior to reproduce, but since 1.1.0 you have to click Start (i.e. the space bar) a lot more (or faster) than in 1.0.5 FWIW.

image

Nornec commented 1 year ago

This appears to have been caused by two things 1) Improper error dialog logic 2) Race conditions with the threads used for playing.

This issue flew under the radar for me because my test bench is extremely performant. Only when I increased the # of objects to a point where I could start to see performance issues did this problem appear for me.

I believe this to be solved in the next beta release for 1.1.0.