search

NoroffFEU / agency-api.noroff.dev

The Unlicense
2 stars 12 forks source link

Not sure what I am doing #107

Closed sakonpatsamit closed 1 year ago

render[bot] commented 1 year ago

Your Render PR Server URL is https://noroff-agency-api-pr-107.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-ci2b8me4dad9gk6bv7e0.

sakonpatsamit commented 1 year ago

@Anclagen

I moved the folder into modules/offer now as you suggested. I was just afraid I would mess up anything if i merged it with the dev branch so I just kept it in the middleware branch.

Anclagen commented 1 year ago

The reason for the dev branch was to allow for messing up a little, extra testing, and getting everything running smoothly. Anything that gets merged into the main gets deployed to the running server, we added protections to dev, like the main so the QA/Scrum Master would check the PRs into it, make sure the code was working then, either approve or request changes, and add some tests. We wanted to make it so all PRs into the main were fully tested and came with a complete passing suite of Jest tests, checking every possible variation of requests we could think of to ensure the desired response was returned.

I suggest you close this PR and open one into the dev branch it shouldn't cause too many problems, and can just be imported into the offer router.

sakonpatsamit commented 1 year ago

alright :) i closed it now