search

NoroffFEU / agency.noroff.dev

Frontend web application for the Noroff Agency API
7 stars 16 forks source link

1041 search bar #1071

Closed MariuszRozycki closed 8 months ago

MariuszRozycki commented 8 months ago

Title

1041 - link to ticket

Describe your changes:

Changes made by @JohanLossius:

  1. Johan's modifications: class="d-none" and id="searchListingContId" add to: pages\listings\index.html Link to changes details/commit - https://github.com/NoroffFEU/agency.noroff.dev/commit/56fd1625b5e7400a6a9c310fe9c9bbc8fe0e7fc0

  2. Display search bar for listings after content loaded. Changes in file: src\js\templates\listings\renderListings.js Link to changes details/commit - https://github.com/NoroffFEU/agency.noroff.dev/commit/090ca4b90111fe664504186fd2390f6fc45ef9d5

Type of changes:

Checklist before requesting a review

Did you run into any issues?

@JohanLossius run issues with pull request as described https://github.com/orgs/NoroffFEU/projects/6/views/1?filterQuery=phoenix&pane=issue&itemId=53763062 Issues fixed with help of QA @MariuszRozycki

@JohanLossius, you have solved the problem #1041 with the search bar displaying during the loading of listings. @NoroffFEU/phoenix , @Tanific , @sulenchy I will merge it to phoenix team branch.

JohanLossius commented 8 months ago

Wonderful @MariuszRozycki! Thanks a lot for the help, quick response when I was having issues! Hugely appreciated! :)