NoroffFEU / agency.noroff.dev

Frontend web application for the Noroff Agency API
7 stars 17 forks source link

Profile page profileRole font with Design Specification #741

Closed MaxMartinsen closed 10 months ago

MaxMartinsen commented 10 months ago

Design view:

Image

Web view:

Image

Description:

There is a mismatch between the font used for the <p id="profileRole" </p> element in the design specification and the current website implementation. The design specifies using the Halcon font for this element, but the website is currently using the Livvic font for all headings (h1 to h6) and body. This inconsistency affects the visual consistency and branding of the website. The goal of this issue is to update the font to meet design specifications while keeping the rest of the headings and body text consistent with the current implementation.

Task:

  1. Review the current SCSS implementation for font family in headers and body.
  2. Update SCSS to use the "Halcon" font for this element, ensuring that it overrides any existing styles.
  3. Test changes across different browsers and devices to ensure compatibility and responsiveness.
  4. Review the design to ensure it matches the intended visual style.

Acceptance Criteria:

zalacop commented 10 months ago

I think this issue has been sorted already when the issue #738 was done. The font is already being applied to the body. But if it's needed, I can specifically add the #profileRole after body.

Image

zalacop commented 10 months ago

Added a screenshot that the font is being applied.

Image