NoroffFEU / agency.noroff.dev

Frontend web application for the Noroff Agency API
7 stars 17 forks source link

Profile page h2 font with Design Specification #742

Closed MaxMartinsen closed 10 months ago

MaxMartinsen commented 10 months ago

Design view:

Image

Web view:

Image

Description:

There was a discrepancy between the font used for the h2 element between the design specification and the current website implementation. The design specifies using the Halcon font for the h2 elements, but the website currently uses the Livvic font for all headings (h1 to h6) and body. This inconsistency affects the visual consistency and branding of the website. The goal of this issue is to update the h2 font to meet design specifications while keeping the rest of the headings and body text consistent with the current implementation.

Task:

  1. Review the current SCSS implementation for the font family in the headers and body.
  2. Update the SCSS to use the "Halcon" font for h2 elements, ensuring that it overrides any existing styles.
  3. Test changes on different browsers and devices to ensure compatibility and responsiveness.
  4. Review the design to ensure it matches the intended visual style.

Acceptance Criteria:

Ninuskaninus commented 10 months ago

This issue was solved in the same PR that fixed the h1 problem, here: Pull request: https://github.com/NoroffFEU/agency.noroff.dev/pull/829