search

Norqy / warp-persist

Automatically exported from code.google.com/p/warp-persist
0 stars 0 forks source link

Move everything into the com.wideplay.warp.persist package hierarchy #20

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
We have com.wideplay.warp.hibernate (etc.) and com.wideplay.warp.util. It
would have been a lot more logical to put everything in the same package
hierarchy. Technically it's too late to change this, but this kind of
breakage might be acceptable for a 2.0. 

I think the only thing in those packages what people were supposed to be
using were the SPRFilters, which we replaced with different ones. We still
have the old ones for backwards compat, so maybe we can just keep those and
move all the rest of the code. Then in the next release we can remove them
altogether.

Original issue reported on code.google.com by robbie.v...@gmail.com on 22 Dec 2008 at 2:43

GoogleCodeExporter commented 9 years ago

Original comment by robbie.v...@gmail.com on 22 Dec 2008 at 2:43

GoogleCodeExporter commented 9 years ago 
I noticed that there are also custom annotations for JPA and DB4O in those 
packages.
So if we do this we will definitely break code. Maybe not worth it?

Original comment by robbie.v...@gmail.com on 23 Dec 2008 at 12:08

GoogleCodeExporter commented 9 years ago 
Let's move everything. Let's also delete the old filters rather than deprecate 
them. We can make this clear if you 
upgrade to wp2. And our docs will be much better this time anyway.

Original comment by dha...@gmail.com on 23 Dec 2008 at 5:30

GoogleCodeExporter commented 9 years ago 
Done, made one filter called PersistenceFilter! I also created an spi package 
and an
internal package.
Do you think we can remove TransactionStrategy? It is deprecated and only has 
"LOCAL"
to choose from.

Original comment by robbie.v...@gmail.com on 23 Dec 2008 at 5:01

GoogleCodeExporter commented 9 years ago 
Yea let's remove it. Btw what is the need for internal? Can't we keep 
everything in .persist as package local?

Original comment by dha...@gmail.com on 24 Dec 2008 at 12:21

GoogleCodeExporter commented 9 years ago 
No, some of our modules like Hibernate / JPA / ... use that code. It's sort of 
like a
"shared" thing that users should not use. I like internal, Guice also does that.

Original comment by robbie.v...@gmail.com on 24 Dec 2008 at 12:36

GoogleCodeExporter commented 9 years ago

Original comment by robbie.v...@gmail.com on 26 Dec 2008 at 11:38