Norstone / norstone.github.io

0 stars 4 forks source link

Broken XL Page #308

Closed RassanGrant closed 5 years ago

RassanGrant commented 6 years ago

@vleong2332 - We had an urgent issue on the site today. I believe the adjustment you made to the XL page yesterday ended up breaking the layout altogether. I created a new branch to fix the issue, but ran into some errors I did not understand, so I abandoned them and edited Develop directly (a no-no).

Anyway, when you get this, can you please:

  1. Correct my work (the fix should have been added to Develop by way of another branch)
  2. Review the work you did previously to figure out what happened and how to correct it
2018-11-02 01 23 30 pm
vleong2332 commented 6 years ago

@RassanGrant Here's what I believe happened.

Was there cloudflare caching that prevented me from seeing the broken page? When did you notice it?

I'm trying to think what I could've done differently to "preview" updates from Forestry. The "preview" functionality seems to not work properly (it doesn't show the css/style). The only thing I could think of is to "simulate" the change locally on my machine, which I'll do from now on when working with Forestry.

RassanGrant commented 5 years ago

@vleong2332 - This all appears correct. Did you actually check the live page once the Webenabled pipeline in Wercker was built? If so, I'm not sure why it passed your checks.

vleong2332 commented 5 years ago

I remember checking it and seeing that it was fine after all the wercker processes were completed. My memory could be wrong.

The only other thing I could think of is that cloudflare cache prevented me from seeing the latest update.