North-Seattle-College / ad440-winter2021-thursday-repo

NSC AD 440 Winter 2021 Thursday cohort practicum repo
Apache License 2.0
2 stars 27 forks source link

[Task] Fix the action for deployment of functions #205

Closed zxkevinxz closed 3 years ago

zxkevinxz commented 3 years ago

Is your feature request related to a problem? Please describe. As a user, I want the Azure Functions to properly deploy.

Describe the solution you'd like When the GitHub Action runs, the Azure Functions are properly deployed to the app.

zxkevinxz commented 3 years ago

Added build on deploy to the options of the github action that deploys the functions, this option was causing the functions not to update properly. Updated the redis key for 2 of the API functions. This will help with a couple of the errors we are getting with functions. Also added the redis key to the functions app on Azure so that os.environ["ENV_REDIS_KEY"] will work.

There were also issues with the get method in the UsersId api function which is causing errors as well. I created a ticket for it, #212

Testing

This will be difficult but can be done by updating a function and merging it, maybe a comment. You'll see the updated function in the Functions App with the comment.

When using the UsersId function to get a user, you should now see this error instead of a password/redis error: Screen Shot 2021-02-26 at 7 37 21 PM

DATE ACTIVITY TIME
2/25 Azure Deploy error research 3 hours
2/25 Testing 1 hour
2/25 Code Review/bug hunt 2.5 hours
2/26 Research and final testing 1.5 hours
2/26 PR/Task updating 0.5 hours