North-Seattle-College / ad440-winter2021-thursday-repo

NSC AD 440 Winter 2021 Thursday cohort practicum repo
Apache License 2.0
2 stars 27 forks source link

Update Workflow orders #233

Open Dylan-Riley opened 3 years ago

Dylan-Riley commented 3 years ago

Resolves: https://github.com/North-Seattle-College/ad440-winter2021-thursday-repo/issues/195

So, testing this will be an issue before it gets merged into development... I was able to use

on:
  repository_dispatch:
    types [$TRIGGER_NAME

to make it so the final step of each workflow is to start the next workflow, but this only works if the workflows are in the default branch in Github. In the linked issue you can see testing I did in my private repo by putting two actions -- one triggers the next -- into the development branch. As far as I can tell from my research there is no way to daisy-chain them like that on an individual test branch.

I also ended up doing it this way since there's more online documentation and help for the repository_dispatch trigger (almost none for workflow_run and the documentation itself leaves something to be desired) and I found a nice guide that introduced it to me and I was able to get to work in small scale.

The only changes are renaming to match conventions, updating the on: trigger, updating the checkout so each subsequent workflow is checking out the same thing, and adding a final step to send the repository_dispatch and some needed info to the next workflow. None of the additional changes mentioned https://github.com/North-Seattle-College/ad440-winter2021-thursday-repo/issues/195#issuecomment-785697435 nor https://github.com/North-Seattle-College/ad440-winter2021-thursday-repo/issues/186 were addressed. Any existing issues still in the workflows as of 4/MAR/2021, 3:26 AM are still there and remain untouched due to testing constraints.

Dylan-Riley commented 3 years ago

Time tracking:

Dylan-Riley commented 3 years ago

Only ten working (presumably) workflows in /.github/workflows/ total, two of which aren't technically on my list.

Missing:

* artillery test for users/{user_id}

* serverless-artillery test for users/{user_id}/tasks/{task_id}

* All slsart UI tests

* Any UI testing aside from /users/

https://github.com/North-Seattle-College/ad440-winter2021-thursday-repo/issues/195#issuecomment-790566366